[Feature] [EDT-1091] Connector instance per image variable #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Feature] Updated doc for getById * [Feature] One connector instance per image var * [Feature] Added ConnectorInstance.source * [Feature] Registering before Unregistering connector * [Feature] Test for new call order * [Feature] Hardcoded grafxMediaConnectorRegistration * [Feature] Logic is moved on engine-side * [Feature] Fix json registration
|
Coverage report can be checked at https://chili-dev.azureedge.net/sdk/coverage/347/coverage.html |
Dvergar
requested review from
brapoprod,
abdelhalimkhouas,
alexandraFlavia9,
pietervp,
pkgacek and
srares76
as code owners
…to feature/EDT-1091-connector-instance-per-image-variable-2
Matthiee
approved these changes
Sep 11, 2023
…to feature/EDT-1091-connector-instance-per-image-variable-2
alexandraFlavia9
approved these changes
Sep 11, 2023
Dvergar
deleted the
feature/EDT-1091-connector-instance-per-image-variable-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ticket: https://chilipublishintranet.atlassian.net/browse/EDT-1091
New behavior uses a
ConnectorRegistrationobject instead of aconnectorId.Every
setImageVariableConnector, will now unregister the old linked connector if it exists and registers a new one.Connectors, when linked to a variable, are now scoped to this very variable: connector options are variable specific.
More undo methods have been added because this was needed for the ticket but connectors register&unregister not being supported (yet) w/ undo&redo: I skipped it for now but still left those already implemented calls.