[Feature] Font families #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…afx-fonts-connector' into feature/EDT-1121-switching-to-grafx-fonts-connector
…dling-font-families' into feature/EDT-1123-methods-for-handling-font-families
EDT-1121-switching-to-grafx-fonts-connector
EDT-1123-methods-for-handling-font-families
…to feature/EDT-1123-methods-for-handling-font-families
evan-mcgeek
requested review from
abdelhalimkhouas,
alexandraFlavia9,
pietervp,
pkgacek and
srares76
as code owners
|
Coverage report can be checked at https://chili-dev.azureedge.net/sdk/coverage/356/coverage.html |
pkgacek
previously approved these changes
Sep 26, 2023
pkgacek
approved these changes
Sep 27, 2023
brapoprod
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has BREAKING CHAGES!
EDT-1121 scope:
Adjusting download method (by removing previewType)
Adding a preview method with previewFormat param
Adding new models: FontFamily + FontStyle
Related tickets
EDT-1123 scope:
FontController methods has been updated to support both FontFamily and FontStyle
FontsChanged -> FontFamiliesChanged subscription