-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add width & height to media detail model #361
[Feature] Add width & height to media detail model #361
Conversation
Coverage report can be checked at https://chili-dev.azureedge.net/sdk/coverage/361/coverage.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also update https://github.com/chili-publish/studio-sdk/blob/main/types/MediaConnector.d.ts to reflect the same changes, would be good to review if the complete api surfacce still matches what we expect.
Ooops, you mentioned it in chat and i completely overlooked that. So I updated both media & font connectors, we do not have preview (font) in getcapabilities so this probably needs to be added as well but i'll prefer not to do it in this ticket. Probably some more cleanup related to that will be done in scope of >> https://chilipublishintranet.atlassian.net/browse/EDT-1172 @evan-mcgeek May I have your eyes 👀 on the font connector side? PS: I'll split again MediaCapabilities/FontCapabilities in a follow-up ticket. |
Just adding some findings. We do have export enum MediaDownloadType {
LowResolutionWeb = 'lowresWeb',
HighResolutionWeb = 'highresWeb',
} Was it an intended constraint to omit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The only thing left is to add a preview
capability to the font connector
…to feature/EDT-1054-Update-connector-detail-models-with-width-and-height
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems non-breaking to me
That was intentional, because WRS should only ever use one of those. |
This PR adds
width
&height
to the model returned by the connectordetail
method.MediaDetail
model is now diverging fromMedia
(query method).Related tickets
https://chilipublishintranet.atlassian.net/browse/EDT-1054