Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Remove multiple frames #392

Merged
merged 8 commits into from
Jan 18, 2024

Conversation

evan-mcgeek
Copy link
Contributor

@evan-mcgeek evan-mcgeek commented Nov 22, 2023

This PR

PR Guidelines

Related tickets

Copy link
Contributor

Coverage Report

Coverage report can be checked at https://cdnepgrafxstudiodev.azureedge.net/sdk/coverage/392/coverage.html

Use PR sdk package

Tarball can be downloaded from https://cdnepgrafxstudiodev.azureedge.net/sdk/dev-packages/392/studio-sdk.tgz

To use in local project, change package.json to use local tarball

"dependencies": {
    "@chili-publish/studio-sdk": "https://cdnepgrafxstudiodev.azureedge.net/sdk/dev-packages/392/studio-sdk.tgz"
}

Copy link
Contributor

github-actions bot commented Nov 22, 2023

Unit Test Results

    1 files    31 suites   38s ⏱️
273 tests 273 ✔️ 0 💤 0
277 runs  277 ✔️ 0 💤 0

Results for commit 44a4152.

♻️ This comment has been updated with latest results.

NicolaVerbeeck
NicolaVerbeeck previously approved these changes Nov 22, 2023
Dvergar
Dvergar previously approved these changes Nov 23, 2023
Copy link
Contributor

@Dvergar Dvergar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we now redirect remove to the new removeFrames and completely remove the exposed removeFrame on engine-side?

@evan-mcgeek
Copy link
Contributor Author

Shouldn't we now redirect remove to the new removeFrames and completely remove the exposed removeFrame on engine-side?

agree, it could be an option. not sure what others think?

@pietervp
Copy link
Member

Shouldn't we now redirect remove to the new removeFrames and completely remove the exposed removeFrame on engine-side?

agree, it could be an option. not sure what others think?

Agree 👍

@evan-mcgeek evan-mcgeek dismissed stale reviews from Dvergar and NicolaVerbeeck via 3b4c9cc January 4, 2024 09:03
@evan-mcgeek evan-mcgeek enabled auto-merge (squash) January 18, 2024 14:45
@evan-mcgeek evan-mcgeek merged commit b8e6ebf into main Jan 18, 2024
4 checks passed
@evan-mcgeek evan-mcgeek deleted the feature/EDT-1187-multiple-frames-remove branch January 18, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants