Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Remove deprecated setChiliToken #422

Merged

Conversation

Dvergar
Copy link
Contributor

@Dvergar Dvergar commented Feb 13, 2024

This PR removes the deprecated setChiliToken method

PR Guidelines

Related tickets

https://chilipublishintranet.atlassian.net/browse/EDT-1034


This is flagged as breaking change since my ticket was also flagged as such. Still this has been deprecated for a few months now.

Copy link
Contributor

Coverage Report

Coverage report can be checked at https://cdnepgrafxstudiodev.azureedge.net/sdk/coverage/422/coverage.html

Use PR sdk package

Tarball can be downloaded from https://cdnepgrafxstudiodev.azureedge.net/sdk/dev-packages/422/studio-sdk.tgz

To use in local project, change package.json to use local tarball

"dependencies": {
    "@chili-publish/studio-sdk": "https://cdnepgrafxstudiodev.azureedge.net/sdk/dev-packages/422/studio-sdk.tgz"
}

Copy link
Contributor

github-actions bot commented Feb 13, 2024

Unit Test Results

    1 files    31 suites   39s ⏱️
283 tests 283 ✔️ 0 💤 0
287 runs  287 ✔️ 0 💤 0

Results for commit 2825f86.

♻️ This comment has been updated with latest results.

@Dvergar Dvergar self-assigned this Feb 13, 2024
…to fix/EDT-1034-Remove-deprecated-setChiliToken-from-SDK-Engine
Copy link
Member

@Matthiee Matthiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@Dvergar Dvergar merged commit 7625db7 into main Feb 21, 2024
4 checks passed
@Dvergar Dvergar deleted the fix/EDT-1034-Remove-deprecated-setChiliToken-from-SDK-Engine branch February 21, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants