Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] [EDT-1338] Add display value for list items (backwards compatibility layer) #426

Merged

Conversation

Matthiee
Copy link
Member

@Matthiee Matthiee commented Feb 22, 2024

Part 1 of 2.

In this PR a backwards compatibility layer is created to keep the contracts working with the new engine feature.

Related tickets

@Matthiee Matthiee self-assigned this Feb 22, 2024
Copy link
Contributor

Coverage Report

Coverage report can be checked at https://cdnepgrafxstudiodev.azureedge.net/sdk/coverage/426/coverage.html

Use PR sdk package

Tarball can be downloaded from https://cdnepgrafxstudiodev.azureedge.net/sdk/dev-packages/426/studio-sdk.tgz

To use in local project, change package.json to use local tarball

"dependencies": {
    "@chili-publish/studio-sdk": "https://cdnepgrafxstudiodev.azureedge.net/sdk/dev-packages/426/studio-sdk.tgz"
}

Copy link
Contributor

github-actions bot commented Feb 22, 2024

Unit Test Results

    1 files    31 suites   40s ⏱️
285 tests 285 ✔️ 0 💤 0
289 runs  289 ✔️ 0 💤 0

Results for commit 3d1a898.

♻️ This comment has been updated with latest results.

@Matthiee Matthiee force-pushed the feature/EDT-1338-add-display-value-for-list-items-part-1 branch from 302e80c to 331dc9e Compare February 23, 2024 10:41
@Matthiee Matthiee changed the title [WIP] [Feature] [EDT-1338] Add display value for list items (backwards compatibility layer) [Feature] [EDT-1338] Add display value for list items (backwards compatibility layer) Feb 23, 2024
@Matthiee Matthiee marked this pull request as ready for review February 23, 2024 10:44
@Matthiee Matthiee requested a review from brapoprod February 23, 2024 10:46
Copy link
Contributor

@Dvergar Dvergar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to export ListVariableItem type from index.ts in this case?

@Matthiee Matthiee requested a review from Dvergar March 1, 2024 07:43
@Matthiee Matthiee force-pushed the feature/EDT-1338-add-display-value-for-list-items-part-1 branch from 6e2a47b to 3d1a898 Compare March 6, 2024 06:02
@Matthiee Matthiee merged commit 8c9c54f into main Mar 6, 2024
4 checks passed
@Matthiee Matthiee deleted the feature/EDT-1338-add-display-value-for-list-items-part-1 branch March 6, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants