Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow barcode frame sources to receive null as a source #447

Merged
merged 5 commits into from
Apr 16, 2024

Conversation

srares76
Copy link
Contributor

@srares76 srares76 commented Apr 15, 2024

This PR allows barcode frame sources to receive null as a source.

PR Guidelines

Related tickets

Screenshots

@srares76 srares76 self-assigned this Apr 15, 2024
@srares76 srares76 requested review from a team as code owners April 15, 2024 10:31
Copy link
Contributor

Coverage Report

Coverage report can be checked at https://stgrafxstudiodevpublic.blob.core.windows.net/sdk/coverage/447/coverage.html

Use PR sdk package

Tarball can be downloaded from https://stgrafxstudiodevpublic.blob.core.windows.net/sdk/dev-packages/447/studio-sdk.tgz

To use in local project, change package.json to use local tarball

"dependencies": {
    "@chili-publish/studio-sdk": "https://stgrafxstudiodevpublic.blob.core.windows.net/sdk/dev-packages/447/studio-sdk.tgz"
}

Copy link
Contributor

github-actions bot commented Apr 15, 2024

Unit Test Results

    1 files    32 suites   38s ⏱️
317 tests 317 ✔️ 0 💤 0
321 runs  321 ✔️ 0 💤 0

Results for commit 2fa7e22.

♻️ This comment has been updated with latest results.

Matthiee
Matthiee previously approved these changes Apr 15, 2024
Copy link
Member

@NicolaVerbeeck NicolaVerbeeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@evan-mcgeek evan-mcgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you read contribution and PR guidelines ? :)

@srares76 srares76 merged commit 1f5cbbc into main Apr 16, 2024
4 checks passed
@srares76 srares76 deleted the feature/null-barcode-source branch April 16, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants