Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDT-1549] set/resetPlaceholder methods #480

Conversation

evan-mcgeek
Copy link
Contributor

@evan-mcgeek evan-mcgeek commented Jul 8, 2024

This PR adds setPlaceholder and resetPlaceholder methods for a Variable

PR Guidelines

Related tickets

Screenshots

@evan-mcgeek evan-mcgeek self-assigned this Jul 8, 2024
@evan-mcgeek evan-mcgeek requested review from a team as code owners July 8, 2024 17:19
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Coverage Report

Coverage report can be checked at https://stgrafxstudiodevpublic.blob.core.windows.net/sdk/coverage/480/coverage.html

Use PR sdk package

Tarball can be downloaded from https://stgrafxstudiodevpublic.blob.core.windows.net/sdk/dev-packages/480/studio-sdk.tgz

To use in local project, change package.json to use local tarball

"dependencies": {
    "@chili-publish/studio-sdk": "https://stgrafxstudiodevpublic.blob.core.windows.net/sdk/dev-packages/480/studio-sdk.tgz"
}

Copy link
Contributor

github-actions bot commented Jul 8, 2024

Unit Test Results

    1 files    36 suites   41s ⏱️
371 tests 371 ✔️ 0 💤 0
381 runs  381 ✔️ 0 💤 0

Results for commit 317c40b.

♻️ This comment has been updated with latest results.

Dvergar
Dvergar previously approved these changes Jul 11, 2024
packages/sdk/src/types/VariableTypes.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/VariableTypes.ts Outdated Show resolved Hide resolved
@evan-mcgeek evan-mcgeek enabled auto-merge (squash) July 19, 2024 11:59
@evan-mcgeek evan-mcgeek merged commit 5fa06e7 into main Jul 19, 2024
4 checks passed
@evan-mcgeek evan-mcgeek deleted the feature/EDT-1549-add-and-expose-placeholder-property-on-variables branch July 19, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants