Skip to content

Commit

Permalink
[Fix][WRS-2253] Update visualization for data source cells (#263)
Browse files Browse the repository at this point in the history
  • Loading branch information
psamusev authored Jan 21, 2025
1 parent 6b581ee commit 50e3892
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 36 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
},
"dependencies": {
"@babel/preset-env": "^7.25.3",
"@chili-publish/grafx-shared-components": "^0.91.2",
"@chili-publish/grafx-shared-components": "^0.91.4",
"@chili-publish/studio-sdk": "^1.18.1-rc.4",
"@fortawesome/fontawesome-svg-core": "^6.7.1",
"@fortawesome/pro-light-svg-icons": "^6.7.1",
Expand Down
32 changes: 1 addition & 31 deletions src/components/dataSource/DataSourceTable.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { AvailableIcons, Icon, LoadingIcon, Table, useInfiniteScrolling } from '@chili-publish/grafx-shared-components';
import { DataItem } from '@chili-publish/studio-sdk';
import { useMemo } from 'react';
import { Center, EmptyStateText, ErrorTextBox, ErrorTextMsg, TableWrapper } from './DataSourceTable.styles';

interface DataSourceTableProps {
Expand Down Expand Up @@ -28,40 +27,11 @@ function DataSourceTable({
onNextPageRequested,
);

// TODO: Remove/Adopt type casting in context of https://chilipublishintranet.atlassian.net/browse/WRS-2253
const transformedData = useMemo(() => {
return data.map((di) =>
Object.entries(di).reduce((transformed, [key, value]) => {
if (typeof value === 'string' || typeof value === 'number') {
// eslint-disable-next-line no-param-reassign
transformed[key] = value;
}
if (value instanceof Date) {
// eslint-disable-next-line no-param-reassign
transformed[key] = value.toISOString();
}
if (typeof value === 'boolean') {
// eslint-disable-next-line no-param-reassign
transformed[key] = `${value}`;
}
if (value === null) {
// eslint-disable-next-line no-param-reassign
transformed[key] = '';
}
return transformed;
}, {} as Record<string, string | number>),
);
}, [data]);

return (
<>
{!error && data.length > 0 && (
<TableWrapper>
<Table
defaultSelectedRow={selectedRow}
rows={transformedData}
onSelectedRowChanged={onSelectedRowChanged}
/>
<Table defaultSelectedRow={selectedRow} rows={data} onSelectedRowChanged={onSelectedRowChanged} />
</TableWrapper>
)}
{dataIsLoading && (
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1307,10 +1307,10 @@
resolved "https://registry.yarnpkg.com/@bcoe/v8-coverage/-/v8-coverage-0.2.3.tgz#75a2e8b51cb758a7553d6804a5932d7aace75c39"
integrity sha512-0hYQ8SB4Db5zvZB4axdMHGwEaQjkZzFjQiN9LVYvIFB2nSUHW9tYpxWriPrWDASIxiaXax83REcLxuSdnGPZtw==

"@chili-publish/grafx-shared-components@^0.91.2":
version "0.91.2"
resolved "https://npm.pkg.github.com/download/@chili-publish/grafx-shared-components/0.91.2/33bd4088bee500125808d46e66f59456164ecc79#33bd4088bee500125808d46e66f59456164ecc79"
integrity sha512-m/a3iRByRWNE38a5VCDAJ5HXtUuJiqkggkJiHaSbAW5N9lusykL2wQT4IHUPWelK34gkEViBoUI5Ez5tg8MgHQ==
"@chili-publish/grafx-shared-components@^0.91.4":
version "0.91.4"
resolved "https://npm.pkg.github.com/download/@chili-publish/grafx-shared-components/0.91.4/0fa039d4d4425e8bcad00b099a10708f37f8fad3#0fa039d4d4425e8bcad00b099a10708f37f8fad3"
integrity sha512-854RkZTGyDoEVC5qZfIBKIoVyLemXvW337kOx3xhkTW1LrbO4IAVn7u2tAbhf6ENSMjssI9E2+5k17VPtbWvQw==

"@chili-publish/studio-sdk@^1.18.1-rc.4":
version "1.18.1-rc.4"
Expand Down

0 comments on commit 50e3892

Please sign in to comment.