Remove deprecated vpc argument to aws_eip

[ascandella]

The vpc = true is throwing deprecation diagnostics. It still works this way, but is not referenced in the documentation anymore.

Ran a terraform plan against my forked version and the plan came up clean (no changes) without any of the warning diagnostics.

[bwhaley]

Thanks for submitting this! To make this even simpler, I think we can just omit vpc and domain. As I understand it, this is a legacy option to support EC2 Classic which is now deprecated by AWS. Using VPC is the default behavior. So I think we should just remove vpc = true and we should be good. 👍

[ascandella]

Ah cool, good point. The docs all show with domain = "vpc" so I assumed it was necessary to get it to do the right thing.

But I just tested a terraform plan and it came up clean with removing the line entirely. Reading the docs it seems like the domain = "vpc" might be a bit safer in case anybody is running this in a VPC with EC2 classic, but it also looks like that may finally be deprecated?

I haven't tested destroying and re-creating the EIP with this branch, though.

[bwhaley]

Worked for me. Thanks for the contribution!