Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(readme): module version in example #99

Merged
merged 1 commit into from
May 14, 2024
Merged

fix(readme): module version in example #99

merged 1 commit into from
May 14, 2024

Conversation

nitrocode
Copy link
Contributor

what

  • corrected version in source
  • added commented out version arg

why

  • best practices in registry usage in terraform

@nitrocode nitrocode requested a review from a team as a code owner May 14, 2024 04:22
bwhaley
bwhaley approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@bwhaley bwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@bwhaley bwhaley merged commit a1f49a0 into chime:main May 14, 2024
@nitrocode nitrocode deleted the patch-1 branch May 26, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwhaley bwhaley bwhaley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @bwhaley