Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 157: make a copy ConfigValue #170

Merged
merged 3 commits into from
Jul 10, 2018
Merged

Fix issue 157: make a copy ConfigValue #170

merged 3 commits into from
Jul 10, 2018

Conversation

aalba6675
Copy link
Contributor

Passing a reference to ConfigValue instead of copy results in unexpected mutation.

Addresses #157.

aalba6675 added 2 commits May 29, 2018 05:36
@aalba6675
tests: add test to ensure no mutation of ConfigValues
ca8c429
@aalba6675
config_parser: don't mutate ConfigValues
5d83ff9 
Avoid mutating ConfigValues when passed as part of ConfigTrees.
Addresses chimpler#157
@coveralls
Copy link

coveralls commented Jun 9, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 96.588% when pulling f73ae31 on aalba6675:fix-issue-157 into 6e38247 on chimpler:master.

@darthbear
Copy link
Member

Thanks @aalba6675 for your PR!

@darthbear darthbear merged commit d398b9f into chimpler:master Jul 10, 2018
@darthbear
Copy link
Member

It was released to pyhocon==0.3.44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aalba6675 @coveralls @darthbear