Fix raising of ConfigException for get_int() and get_float() #180 #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#180 This fixes issue chimpler#180 "get_int() and get_float() don't raise ConfigException if wrong type". Calling get_int() and get_float() on a key that is not accepted by int() or float() would result in TypeError or ValueError instead of ConfigException. These cases are now handled.
1 similar comment
|
Thank you @ElkMonster for your PR! |
|
Thanks @ElkMonster for your contribution. Your fix was pushed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #180 "get_int() and get_float() don't raise ConfigException if
wrong type". Calling get_int() and get_float() on a key that is not accepted
by int() or float() would result in TypeError or ValueError instead of
ConfigException. These cases are now handled.