Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supoort conversion of numerically-index objects to arrays #189

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

lune-sta
Copy link
Contributor

@lune-sta lune-sta commented Nov 7, 2018

I tried to implement conversion of numerically-index objects to arrays.
Tell me if there's even a little mistake.

https://github.com/lightbend/config/blob/master/HOCON.md#conversion-of-numerically-indexed-objects-to-arrays

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.632% when pulling 1fc2eb0 on lune-sta:feature/objects_to_arrays into 0390324 on chimpler:master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.632% when pulling 1fc2eb0 on lune-sta:feature/objects_to_arrays into 0390324 on chimpler:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.632% when pulling 1fc2eb0 on lune-sta:feature/objects_to_arrays into 0390324 on chimpler:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.632% when pulling 1fc2eb0 on lune-sta:feature/objects_to_arrays into 0390324 on chimpler:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.632% when pulling 1fc2eb0 on lune-sta:feature/objects_to_arrays into 0390324 on chimpler:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.632% when pulling 1fc2eb0 on lune-sta:feature/objects_to_arrays into 0390324 on chimpler:master.

@darthbear
Copy link
Member

Thanks @lune-sta for your PR!

@darthbear darthbear merged commit 3ce6821 into chimpler:master Nov 15, 2018
@darthbear
Copy link
Member

Thanks @lune-sta for your contribution. Your fix was pushed to pyhocon==0.3.48

@lune-sta
Copy link
Contributor Author

@darthbear Thank you for the merge!
Please also check the "Conversion of numerically-index objects to arrays" status in README :)

@darthbear
Copy link
Member

Thank you! 👍 I just did!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants