Handle ConfigValues and ConfigSubstitution in HOCONConverter.to_hocon #192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As also mentioned by Ivan@renardeinside on gitter, I encountered this bug and made a fix for it (plus a test):
Hi everyone.
I found something strange in HOCONConverter.convert(config,"hocon").
Probably i haven't enough understanding, but if you want to convert come config with unresolved substitution, you got strange result.
Suppose, you have file like this
parameter = ${substition.v1}
Then you parse this file and you won't resolve substitution:
config = ConfigFactory.parse_file("example.conf",resolve=False)
Then if you convert this config you got this result code:
print(HOCONConverter.convert(config,"hocon"))
output:
parameter = [ConfigValues: [ConfigSubstitution: substition.v1]]
But probably the result should be:
parameter = ${substition.v1}