Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSdocs #1029

Merged
merged 4 commits into from
Feb 27, 2023
Merged

Update JSdocs #1029

merged 4 commits into from
Feb 27, 2023

Conversation

chintan9
Copy link
Owner

@chintan9 chintan9 commented Feb 2, 2023

Update JSdocs

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Feb 2, 2023
@chintan9 chintan9 requested a review from realamirhe February 2, 2023 22:58
@chintan9 chintan9 marked this pull request as ready for review February 2, 2023 22:58
@ghost
Copy link

ghost commented Feb 2, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@guardrails
Copy link

guardrails bot commented Feb 2, 2023

⚠️ We detected 13 security issues in this pull request:

Vulnerable Libraries (13)
Severity Details
Medium pkg:npm/react@17.0.2@17.0.2 (t) - no patch available
High pkg:npm/json5@1.0.1@1.0.1 (t) upgrade to: 2.2.2
High pkg:npm/fb-watchman@2.0.1@2.0.1 (t) - no patch available
N/A pkg:npm/debug@2.6.9@2.6.9 (t) upgrade to: 3.1.0
Critical pkg:npm/gh-pages@4.0.0@4.0.0 (t) - no patch available
High pkg:npm/loader-utils@2.0.4@2.0.4 (t) - no patch available
High pkg:npm/shelljs@0.8.5@0.8.5 (t) - no patch available
Medium pkg:npm/nwsapi@2.2.0@2.2.0 (t) - no patch available
High pkg:npm/json@11.0.0@11.0.0 (t) - no patch available
High pkg:npm/json5@2.2.1@2.2.1 (t) upgrade to: 2.2.2
High pkg:npm/decode-uri-component@0.2.2@0.2.2 (t) - no patch available
High pkg:npm/json5@0.5.1@0.5.1 (t) - no patch available
Low pkg:npm/node-fetch@2.6.7@2.6.7 (t) - no patch available

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@vizipi
Copy link

vizipi bot commented Feb 2, 2023

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
33.33 % tractorcow 1 1
33.33 % Paweł Lula 1 1

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold


Committed file ranks

(click to expand)
  • 98.21%[src/index.tsx]
  • 99.74%[package-lock.json]
  • 99.49%[package.json]
  • Copy link
    Collaborator

    @realamirhe realamirhe left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM, but can be enhanced

    src/index.tsx Show resolved Hide resolved
    src/index.tsx Outdated Show resolved Hide resolved
    src/index.tsx Outdated Show resolved Hide resolved
    src/index.tsx Outdated Show resolved Hide resolved
    chintan9 and others added 3 commits February 8, 2023 16:14
    Co-authored-by: Amir.H Ebrahimi <amirhosseinebrahimi77@gmail.com>
    Co-authored-by: Amir.H Ebrahimi <amirhosseinebrahimi77@gmail.com>
    Co-authored-by: Amir.H Ebrahimi <amirhosseinebrahimi77@gmail.com>
    @sonarqubecloud
    Copy link

    sonarqubecloud bot commented Feb 8, 2023

    Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

    Bug A 0 Bugs
    Vulnerability A 0 Vulnerabilities
    Security Hotspot A 0 Security Hotspots
    Code Smell A 0 Code Smells

    No Coverage information No Coverage information
    0.0% 0.0% Duplication

    @chintan9 chintan9 merged commit 64e272b into master Feb 27, 2023
    @trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Feb 27, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ✨ Merged Pull Request has been merged successfully size/S
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants