Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure imported css declared as side effects #883

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tractorcow
Copy link

This resolves an issue when using import "plyr-react/plyr.css" where webpack would incorrectly detect that as an unused import and tree shake it away.

see gatsbyjs/gatsby#19446 for context

@sourcelevel-bot
Copy link

Hello, @tractorcow! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jun 29, 2022
@vizipi
Copy link

vizipi bot commented Jun 29, 2022

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00 % Chintan Prajapati 152 2
100.00 % amirHossein-Ebrahimi 42 2

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
package-lock.json82.76 %24 out of 29 times
rollup.config.js41.38 %12 out of 29 times

Committed file ranks

(click to expand)
  • 99.23%[README.md]
  • 99.49%[package.json]
  • @vizipi vizipi bot requested a review from chintan9 June 29, 2022 03:25
    @sonarcloud
    Copy link

    sonarcloud bot commented Jun 29, 2022

    Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

    Bug A 0 Bugs
    Vulnerability A 0 Vulnerabilities
    Security Hotspot A 0 Security Hotspots
    Code Smell A 0 Code Smells

    No Coverage information No Coverage information
    0.0% 0.0% Duplication

    @chintan9 chintan9 requested a review from realamirhe July 12, 2022 18:47
    @trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jul 21, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ✅ Approved Pull Request has been approved and can be merged size/XS
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants