Mark css files as side effects

[desfero]

Right now production build of parcel (and all other bundlers that take into account sideEffects flag) removes the css files completely from the bundle.

Specifying explicitly that css has side effects would solve the issue.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[vizipi]

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match %	Person	Commit Count	Common Files
100.00%	Chintan Prajapati	103	1
100.00%	amirHossein-Ebrahimi	29	1
100.00%	tractorcow	1	1

---

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)

File	Percentile	rate
package-lock.json	91.20%	808 out of 886 times

---

Committed file ranks

(click to expand)

99.49%[package.json]

[cesarenaldi]

Any update on this PR? Can it be merged?

[ghost]

👇 Click on the image for a new way to code review

Legend

[realamirhe]

Hey @desfero nad @cesarenaldi

We copy the CSS file after building in postbuild our scripts

plyr-react/package.json

Lines 52 to 56 in 0e6459f

	"postbuild": "npm run copy",
	"precopy": "shx cp -r dist/src/* dist/esm && shx cp -r dist/src/* dist && shx rm -rf dist/src && shx rm -rf dist/{src,tests}",
	"copy": "concurrently -m 8 'npm:copy:*'",
	"copy:package-json": "shx cp package.json dist && json -I -f dist/package.json -e 'this.private=false; this.devDependencies=undefined; this.scripts=undefined; this.publishConfig=undefined'",
	"copy:static-content": "shx cp README.md LICENSE dist",

I checked the latest version of dist.tarball from npm view command and it seems that we have the plyr.css in our final build.

I always thought that the "sideEffects" is mostly going to be used for tree-shaking.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[realamirhe]

it changes the side effect property for all end devs so it needs more investigation before merging!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[al-petrushin]

Any update here? 🤔

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud