Support the workflow_run event #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to enhance security around github token handling means that PRs merged to a target branch by github native dependabot no longer receive a write access token by default. Instead it is required to have a push workflow trigger a workflow_run subsequently that is provided with write access. To support this add a route and handler function for workflow_run events that reuses much of the functionality from the push handler by moving the common capabilities to a shared function. Includes a check to skip such a workflow if it is triggered via pull_request events instead until such time as someone can add the required support using the existing pull_request handler for the common pieces. Adds tests following the same pattern for the handlePull function.
chinthakagodawita
force-pushed
the
workflow-run-event
branch
from
d977f44 to
fb31698
Compare
Also adds typings for incoming event data and auto mocks in tests based off the event typing.
chinthakagodawita
force-pushed
the
workflow-run-event
branch
from
fb31698 to
2a7b4fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 439 475 +36
Branches 87 96 +9
=========================================
+ Hits 439 475 +36
Continue to review full report at Codecov.
|
|
Manual test passing. |
This was referenced Apr 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#138 with:
Closes #138