Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to filter PRs based on ready state #183

Merged

Conversation

pjohnmeyer
Copy link
Contributor

Implements #176.

b83873d goes against the style of the rest of the tests a little, so if you want me to revert it out and make the tests more linear I can. I just wanted to do a little refactoring of the work I did before I put this up.

src/autoupdater.ts Outdated Show resolved Hide resolved
@pjohnmeyer pjohnmeyer marked this pull request as draft June 19, 2021 05:55
@pjohnmeyer pjohnmeyer marked this pull request as ready for review June 19, 2021 15:05
@chinthakagodawita chinthakagodawita self-requested a review June 22, 2021 07:15
Copy link
Owner

@chinthakagodawita chinthakagodawita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple, great work! Just have a very minor comment - let me know what you think

src/autoupdater.ts Outdated Show resolved Hide resolved
src/autoupdater.ts Outdated Show resolved Hide resolved
@chinthakagodawita
Copy link
Owner

I've also tested this manually and it does exactly what it says on the tin 🎉

Co-authored-by: Chin Godawita <1452384+chinthakagodawita@users.noreply.github.com>
@pjohnmeyer
Copy link
Contributor Author

@chinthakagodawita incorporated your suggestions, thanks!

Copy link
Owner

@chinthakagodawita chinthakagodawita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chinthakagodawita chinthakagodawita merged commit 9b68d45 into chinthakagodawita:master Jun 24, 2021
@chinthakagodawita
Copy link
Owner

Released in v1.5.0, thanks again! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants