Skip to content

Use new std::io module #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2015
Merged

Use new std::io module #20

merged 4 commits into from
Feb 23, 2015

Conversation

robo9k
Copy link

@robo9k robo9k commented Feb 11, 2015

This is a work-in-progress to port the code to the new std::io module.

Note that std::io itself contains the following warning:

NOTE: This module is very much a work in progress and is under active development. At this time it is still recommended to use the old_io module while the details of this module shake out.

As such, do not merge until the dust has settled ✋

@jakerr
Copy link
Member

jakerr commented Feb 13, 2015

Looking good so far 😄 Thank you for your proactivity in starting this!

@robo9k
Copy link
Author

robo9k commented Feb 15, 2015

Note that the Travis cargo build fails due to a rustc ICE in Piston/image, see https://travis-ci.org/chip8-rust/chip8-ui/builds/50792473#L2697
I did not investigate this any further or reported in anywhere upstream, but I don't think it's a problem with this pull request's code changes.

Edit: So this ICE is already a few days old, see rust-lang/rust#21756 (comment)

robo9k pushed a commit that referenced this pull request Feb 15, 2015
This includes image-rs/image#297, so the rustc ICE observed
in #20 should be gone.
@robo9k
Copy link
Author

robo9k commented Feb 15, 2015

Rebased onto aa5d470. Now this fails as expected, since chip8-rust/chip8-vm#2 has not been merged after the split.

@robo9k
Copy link
Author

robo9k commented Feb 22, 2015

Even though I've successfully merged the chip8_vm part (though no new crate version yet), this pull request here fails to build due to a problem with rust-sdl2, so we're a little stuck.

@robo9k
Copy link
Author

robo9k commented Feb 23, 2015

Okay, the issue with rust-sdl2 is fixed by 9a3a31a. I get a new nasty error about

SDL not built with haptic (force feedback) support

however USE=haptic emerge libsdl2 fixed that for now (might be a bug in Gentoo's stable media-libs/libsdl2).

robo9k pushed a commit that referenced this pull request Feb 23, 2015
Use new `std::io` module
@robo9k robo9k merged commit e37cbe7 into master Feb 23, 2015
@robo9k robo9k deleted the new-io branch February 23, 2015 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants