Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Macro potential issue #591

Open
nikola-kovacevic-ns opened this issue Sep 12, 2024 · 1 comment
Open

Package Macro potential issue #591

nikola-kovacevic-ns opened this issue Sep 12, 2024 · 1 comment
Labels
Approved bug Something isn't working duplicate This issue or pull request already exists

Comments

@nikola-kovacevic-ns
Copy link

nikola-kovacevic-ns commented Sep 12, 2024

Hello,

Caliptra in package definitions has following macro:

`ifndef PRIM_ASSERT
`define CALIPTRA_PRIM_ASSERT

Is this intentional? Shouldn't it be like this:

`ifndef CALIPTRA_PRIM_ASSERT
`define CALIPTRA_PRIM_ASSERT

It is causing problems when integrating caliptra with other cores wich have the same lowrisc ibex base RTL code.

Thanks in advance,
Kovacevic Nikola

@calebofearth calebofearth added bug Something isn't working duplicate This issue or pull request already exists labels Sep 13, 2024
@calebofearth
Copy link
Collaborator

Hi, this is a duplicate of #332, which is a follow-up from #56.
This is intended to be exclusively a reference to CALIPTRA_PRIM_ASSERT as you pointed out and will be fixed for the 2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants