Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preprocessor placement gives error #950

Closed
jefflfree opened this issue Sep 24, 2021 · 1 comment
Closed

preprocessor placement gives error #950

jefflfree opened this issue Sep 24, 2021 · 1 comment
Labels
preprocessor anything related to preprocessing (conditionals, macros, etc.) rejects-valid syntax If the parser wrongly rejects syntactically valid code (according to SV-2017).

Comments

@jefflfree
Copy link

Describe the bug

If I put `else in the middle of a module declaration (before ;) it fails. This is valid code.

To Reproduce
ifndef three module test1 else
module test2
`endif
;
endmodule

Did it reject valid code? or crash?
./verible-verilog-lint blah.v
blah.v:3:1: syntax error, rejected "`else" (syntax-error).
blah.v:7:1: syntax error, rejected "endmodule" (syntax-error).

Expected behavior

A clear and concise description of what you expected to happen. Citations to the
SystemVerilog-2017 Standard (LRM)
would help.

@jefflfree jefflfree added the rejects-valid syntax If the parser wrongly rejects syntactically valid code (according to SV-2017). label Sep 24, 2021
@tgorochowik tgorochowik added the preprocessor anything related to preprocessing (conditionals, macros, etc.) label Sep 24, 2021
@tgorochowik
Copy link
Member

Hi!

Thanks for filing this issue. Unfortunately Verible does not handle preprocessing very well at this point. Also see: #183

Having a proper preprocessor is certainly on our TODO list though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preprocessor anything related to preprocessing (conditionals, macros, etc.) rejects-valid syntax If the parser wrongly rejects syntactically valid code (according to SV-2017).
Projects
None yet
Development

No branches or pull requests

2 participants