WIP: Use FZF backend instead #31
Conversation
|
@chardskarth Thanks for your work, I want to try your branch, can you tell me how install your branch, before merge it into the main. Thanks. |
|
@mingsu hi there! I don't recommend merging this to main. I took a very different approach. Feel free to try my branch. Go ahead and clone and do a "make install" there. You should be able to build it. |
Thanks for your reply. I tried to build it, without success. Can you provide a binary so that I can try? |
|
for me worked just by calling but works not really like fzf: (all commands call from root of this repo)
for me, it looks like if there is no 100% (sequence of letters, then we got nothing)
|
| [task setLaunchPath:@"/bin/zsh"]; | ||
|
|
||
| NSArray *arguments = [NSArray arrayWithObjects: @"-c", | ||
| [NSString stringWithFormat:@"echo \"%@\" | fzf --reverse --exact --filter \"%@\"", options, query], nil]; |
There was a problem hiding this comment.
remove please --exact that is what I mention in comment
#31 (comment)
or even better make that string as option that can be passed to application during execution (with default fallback) - that way each user can customize in any way
|
Hi @justgook thanks for the review 🙏 but I won't be working on this (at least not anytime soon). It works for my use case. Feel free to fork and remove "--exact" option.. or even better, you can add changes in this MR. |
Regardng #23, I haven't thought of a way to support FZF and ended up using fzf as the backend instead.