Fix OrgPromise:next() being triggered before original promise is finished #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipsenkbeil
changed the title
|
@kristijanhusak I'm not sure why, but for neovim nightly my test kept failing where I create a window and (optionally) switch focus to it. The solution was to remove the promise chaining I was doing, and instead inline the call to set the focused window. This doesn't make sense to me, but figured I'd highlight it in case there's something weird about neovim nightly that's messing with the promise library in orgmode. |
Closed
chipsenkbeil
added a commit
that referenced
this pull request
May 6, 2024
…shed (#29) * Fix focusing of roam buffer by inlining the call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.