Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting an optional "desc" on keymaps #63

Closed
wants to merge 11 commits into from

Conversation

snoblenet
Copy link

No description provided.

@chipsenkbeil
Copy link
Owner

@snoblenet let me know when this is ready for review and I'll kick off the automated tests 😄

@snoblenet
Copy link
Author

@snoblenet let me know when this is ready for review and I'll kick off the automated tests 😄

@snoblenet let me know when this is ready for review and I'll kick off the automated tests 😄

I believe it is ready. Is there a button I must click to indicate this is the case?

@chipsenkbeil
Copy link
Owner

chipsenkbeil commented Sep 12, 2024

@snoblenet let me know when this is ready for review and I'll kick off the automated tests 😄

@snoblenet let me know when this is ready for review and I'll kick off the automated tests 😄

I believe it is ready. Is there a button I must click to indicate this is the case?

I have to trigger it, which I just did :) looks like something is broken, but on my phone so haven't had the chance to look.


Screenshot_20240912_092136_GitHub.jpg

Your test is failing, I believe.

@snoblenet snoblenet closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants