Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support status fn for StatusManager #27

Merged
merged 17 commits into from
Sep 17, 2024

Conversation

greenhat616
Copy link
Contributor

@greenhat616 greenhat616 commented Jul 12, 2024

Close #5

use a enum ServiceStatus to represent the services state:

pub enum ServiceStatus {
    NotInstalled,
    Running,
    Stopped(Option<String>), // Provide a reason if possible
}
  • finish all related managers
  • add test suits
  • add decoding support for among differnet windows code page

@greenhat616 greenhat616 marked this pull request as draft July 12, 2024 16:17
@greenhat616 greenhat616 marked this pull request as ready for review July 13, 2024 14:36
@greenhat616
Copy link
Contributor Author

@jacderida Ready to CI run. Thx

@chipsenkbeil
Copy link
Owner

I just realized this has been sitting here. @jacderida @greenhat616 this is something ready for review?

@greenhat616
Copy link
Contributor Author

greenhat616 commented Aug 24, 2024

@chipsenkbeil Hi. I think it is ready for review, and i have use this patch in https://github.com/LibNyanpasu/nyanpasu-service.

I have manually test the all platform expect the rc.d which I don't own the test environment
And I changed the test suite to ensure the service status current while the service state changed(install, start, stop, uninstall etc).

@chipsenkbeil
Copy link
Owner

@greenhat616 hm, I'm not sure why the automated tests aren't running. The button for me to trigger them seems to be missing.

I'll take a look at running manually this weekend and get this merged in. Sorry for waiting so long!

@chipsenkbeil
Copy link
Owner

@greenhat616 ran parts of it this weekend. Going to merge and anything that needs to change before the next release can sneak in over the week.

Thanks again for the PR!

@chipsenkbeil chipsenkbeil merged commit 13dae5e into chipsenkbeil:main Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Print the status of service?
2 participants