-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pinning featured posts option #353
Conversation
dd8eee5
to
c335778
Compare
Looks like a good feature. Same as the other PR, haven't tested locally yet but approving the test builds. |
9145c86
to
2c4bfaf
Compare
The last push is to fix the variable name style |
2c4bfaf
to
36c3227
Compare
Fix missing signoff issue, should be all good after being approved |
[Edit: Nevermind about what I posted earlier; it was an error on my end.] I would suggest changing the comment for
since as I read the code it looks like this param doesn't need to be set in order for the pinning to work (which is good). Also, somewhat tangentially related to this PR, I noticed that we have a "featured" tag, but that posts are only featured when |
Tested and confirmed that this works; sorry about the false negative I reported in the previous comment. See my suggestion about the comment; otherwise this looks good. Thanks for contributing @LukeHong! |
Signed-off-by: Luke Hong <luke0724@hotmail.com>
36c3227
to
e1d52af
Compare
@rootwork I also add it to the comment for |
Looks great! And you're right, good catch. Going to merge. Thanks for this contribution as well @LukeHong! |
Above does not seem to work. Using latest Hugo and Clarity:
Am I missing anything? |
Replied at #451 . |
This PR...
Changes / fixes
Screenshots (if applicable)
Checklist
Ensure you have checked off the following before submitting your PR.