Add audio mime types #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirag04
reviewed
Nov 8, 2017
| mimeType = @"application/zip"; | ||
| } else if ([attachmentType isEqualToString:@"text"]) { | ||
| mimeType = @"text/*"; | ||
| } else if ([attachmentType isEqualToString:@"mp3"]) { |
There was a problem hiding this comment.
at this point, it might be worth using a switch statement here. @adamski you wanna tackle that now?
i'm ok with shipping this as is too.
There was a problem hiding this comment.
Objective-C (like C) only supports integer values for switch statements, so not possible I'm afraid, although there are some workarounds that can look similar. I think its simpler to leave it as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few common audio file types: mp3, wav, aiff, ogg and flac.