Fix function signature mismatches for WebAssembly #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It does not always boost speed
- In system that 'unsigned long' is 32-bit(i.e. Windows, 32-bit Linux) - https://sourceforge.net/p/soxr/discussion/general/thread/5d68180432/
- Still it makes same output for same input
(https://bitbucket.org/jpommier/pffft) - fix: add define for 32bit x86 iOS simulator - Add missing include for altivec - fix ppc/ppc64 detection for GCC, fix vector initialization
- Add __i386__ check
- Fix run-time NEON SIMD check
- Add NEON detection w/o libavutil - Remove libavutil dependency with ARM
This was referenced Nov 3, 2024
swnf
force-pushed
the
fix-function-signature-mismatches
branch
from
983ea3d to
7cc42a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the mismatch between the function signatures in
fft4g*andrdft_t.h. On most platforms this is not an issue, but some platforms like WebAssembly don't support calls with mismatching function signatures.