-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some base functions are not virtual and thus can't be overridden by default. #358
Comments
We can change them to virtual. |
Btw, curious, what is your use case for overriding these functions? |
Thanks, that'd be great. |
Just a disclaimer, we will very most likely reject extension proposals though. |
We're writing this extension for our project. No worries if/when it gets rejected. |
Some base functions are not virtual and thus can't be overridden by default.
For example, ownerOf(), balanceOf(), etc.
Is there any reason behind that design decision ? Openzeppelin has theirs all virtual to allow the most amount of extensions/customizations.
I have a use case for an extension to ERC721A that would involve modifying the logic post-mint. I'm fine with simply changing those functions to virtual in my source code, but was also wondering if there's more to that design decision that I might be missing.
The text was updated successfully, but these errors were encountered: