Make all public and internal functions virtual #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vectorized
changed the title
Vectorized
changed the title
cygaar
approved these changes
Jul 8, 2022
|
I came here specifically to ask for this. Reasoning - quirky token id system needs extra functions overriding. I'd rather do it in a way which keeps me in sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #358
To be honest, part of my OCD is triggered when functions that are dangerous to be overridden are marked virtual.
But a wise comment from a comrade soothed me.
https://twitter.com/rage_pit/status/1545423297667555328?s=20&t=o7Ijl8TrbjRSpXshoqIozA
OpenZeppelin and Solmate recently marked their functions as virtual too.