Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed zero address check on _numberMinted #160

Merged
merged 2 commits into from
Mar 12, 2022

Conversation

BenSparksCode
Copy link
Contributor

There is already a zero address check on mint, so you can safely check the zero address via this view function - it should always return zero.

Verified

This commit was signed with the committer’s verified signature.
thecsw Sandy
@Vectorized
Copy link
Collaborator

Nice find! Love it. 🧠

@ahbanavi
Copy link
Contributor

Should we consider removing BurnedQueryForZeroAddress or AuxQueryForZeroAddress too?

@Vectorized
Copy link
Collaborator

Vectorized commented Mar 10, 2022

Should we consider removing BurnedQueryForZeroAddress or AuxQueryForZeroAddress too?

@ahbanavi Yes. Wow, you can read my mind.

When removing the other checks, do also remove the relevant tests too.

balanceOf still needs the check due to the ERC721 standard.

@Vectorized
Copy link
Collaborator

Going to merge this after #165.

@ahbanavi We can make a separate PR for the other removals instead.

@ahbanavi
Copy link
Contributor

ahbanavi commented Mar 12, 2022

@Vectorized Other removals can wait for another PR.
But IMO, this line should also be removed in this one:

error MintedQueryForZeroAddress();

Verified

This commit was signed with the committer’s verified signature.
thecsw Sandy
@BenSparksCode
Copy link
Contributor Author

@ahbanavi @Vectorized done :)

@Vectorized Vectorized merged commit fe89f9d into chiru-labs:main Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants