Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unify internal function style #161

Merged
merged 1 commit into from
Mar 10, 2022
Merged

chore: unify internal function style #161

merged 1 commit into from
Mar 10, 2022

Conversation

antoncoding
Copy link
Contributor

All internal functions are prefixed with _ except ownershipOf. Should be slightly better to have unified style.

ahbanavi
ahbanavi suggested changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@ahbanavi ahbanavi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, but IMHO you should remove package-lock.json from the changes.

@antoncoding antoncoding force-pushed the chore/rename-internal branch from b340108 to 272bc3e Compare March 10, 2022 08:50
@Vectorized Vectorized merged commit 9742b1a into chiru-labs:main Mar 10, 2022
@ahbanavi ahbanavi mentioned this pull request Mar 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahbanavi ahbanavi ahbanavi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antoncoding @ahbanavi @Vectorized