Docs update #231
Merged
Docs update #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Austinhs
reviewed
Apr 8, 2022
docs/erc721a-queries.md
Outdated
| multiple smaller scans if the collection is large enough to | ||
| cause an out-of-gas error. | ||
|
|
||
| This function should work fine for 10k PFP collections. |
There was a problem hiding this comment.
Thoughts on maybe adding a similar comment for a size that would not work?
There was a problem hiding this comment.
Something like:
Should be avoided for collections > 30K (arbitrary number, btw), and should NOT be used for dynamic supplies like breeding.
(If we don't wanna go through the testing to figure out the limitation, might just mention that its only been tested on 10K collections)
There was a problem hiding this comment.
I am purposely vague about the limit, because different RPC providers may have different gas limits on view functions.
Also, these limits may change over time (e.g. Ethereum's max block gas limit).
Austinhs
approved these changes
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged just before publishing next version.