New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add override and remove immutable in function to fit version under v0.8.8 #255

Merged

Vectorized merged 1 commit into chiru-labs:main from tn606024:fit-version-under-0.8.8

Apr 28, 2022

Contributor

tn606024 commented Apr 28, 2022

contract's solidity version is solidity ^0.8.4, but in code use two feature only support ^0.8.8.

https://blog.soliditylang.org/2021/09/27/solidity-0.8.8-release-announcement/

you can see No Override for Interface Functions and Reading From Immutable Variables in this article.

so to fit contract version under 0.8.8, I add override for Interface function and remove read immutable variable in one mock contract.


          contracts: add override and remove immutable

0a39c07

Collaborator

Vectorized commented Apr 28, 2022

Thanks! Nice catch.

Vectorized merged commit 996771f into chiru-labs:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet