Use uint packing instead of structs #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cygaar
changed the title
This was
linked to
issues
May 9, 2022
Closed
Vectorized
force-pushed
the
feature/bitwise
branch
2 times, most recently
from
3597937
to
67979b0
Compare
|
~ just an idea: |
|
I think it's still okay to directly write the bitwise ops inline to have a little more control. |
Vectorized
force-pushed
the
feature/bitwise
branch
3 times, most recently
from
7be400d
to
1dcd84a
Compare
Vectorized
force-pushed
the
feature/bitwise
branch
from
1dcd84a
to
8f78a35
Compare
Vectorized
force-pushed
the
feature/bitwise
branch
from
8f78a35
to
9f519d7
Compare
cygaar
requested changes
May 14, 2022
Vectorized
commented
May 15, 2022
Vectorized
commented
May 15, 2022
Vectorized
commented
May 15, 2022
Vectorized
commented
May 15, 2022
cygaar
reviewed
May 15, 2022
cygaar
approved these changes
May 15, 2022
|
Let's do one more poll to see how people feel about this |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made in preparation for #267.
This is a breaking change, as the internal
_ownershipsmapping is renamed to_packedOwnerships.Using uints allow us to write most of the packing logic in Solidity instead of assembly. This allows us to keep the code compatible with the diamonds transpiler we are planning to use in the near future. Also, it is easier to read, and surprisingly more performant.
This PR is inspired by and includes #270. I’ve tried the idea with structs: it added quite a bit of overhead because of the many values that are often needlessly unpacked by the compiler. Manual unpacking allows us to achieve a much lower overhead.
Additional tests have been added to ensure that the
startTimestamps are packed / unpacked properly.Before:
After: