Rename to _msgSenderERC721A #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After removing OpenZeppelin dependency, we have to rename our
_msgSender()to something else to prevent name collision when people import OpenZeppelin (e.g. when using Ownable). Name collision will cause a drop in Quality of Life.When writing GSN compatible contracts, we will simply override the new function and return
_msgSender().As per twitter poll https://twitter.com/optimizoor/status/1525402330900086784 , we shall rename it to
_msgSenderERC721Afor aesthetics.