Remove ERC721ASetOwnersExplicit extension #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cygaar
commented
May 24, 2022
test/ERC721A.test.js
Outdated
| // We assume the initialization worked due to less gas used by the 2nd txn | ||
| const receipt1 = await tx1.wait(); | ||
| const receipt2 = await tx2.wait(); | ||
| expect(receipt1.gasUsed.toNumber()).to.be.greaterThan(receipt2.gasUsed.toNumber()); |
There was a problem hiding this comment.
This is a best-efforst heuristic to determine whether or not the initialization call worked because we can't directly access _packedOwnerships
There was a problem hiding this comment.
We can access _ownershipAt, which is internal.
But big brain trick haha.
cygaar
commented
May 24, 2022
test/ERC721A.test.js
Outdated
| // We assume the initialization worked due to less gas used by the 2nd txn | ||
| const receipt1 = await tx1.wait(); | ||
| const receipt2 = await tx2.wait(); | ||
| expect(receipt1.gasUsed.toNumber()).to.be.greaterThan(receipt2.gasUsed.toNumber()); |
There was a problem hiding this comment.
This is a best-efforst heuristic to determine whether or not the initialization call worked because we can't directly access _packedOwnerships
|
So many lines gone. Finally the itch got scratched. :) LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The impetus for removing this extension is to simplify our codebase and remove code adds unnecessary complexity. This code was added as a fail safe when ERC721A was first written, but we've since added optimizations and other helpers that make this unnecessary. Like @Vectorized mentioned in the issue below, contract owners can use
_initializeOwnershipAtat certain intervals to make transfers of large batch mints cheaper. Other than that scenario, it's not very necessary to explicitly set an ownership slot because the added cost of transferring an uninitialized slot isn't very high.#289