Add a generic interface for ownership storage hitchhiking #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxkoda
commented
Jun 12, 2022
contracts/ERC721A.sol
Outdated
Comment on lines
648
to
653
| _packedOwnerships[tokenId] = | ||
| _addressToUint256(from) | | ||
| (block.timestamp << BITPOS_START_TIMESTAMP) | | ||
| (_extraData(from, address(0), _unpackExtraData(prevOwnershipPacked)) << BITPOS_EXTRA_DATA) | | ||
| BITMASK_BURNED | | ||
| BITMASK_NEXT_INITIALIZED; |
There was a problem hiding this comment.
One of my new tests for the behavior of _extraData failed for burns on my machine. I was able to track it back to the _addressToUint256(from) part in the above code. Replacing it with (_addressToUint256(from) & ((1 << 160) - 1)) |, so zeroing the leading 96bits solved the issue. I have no idea why _addressToUint256 seems to produce dirty uint256s though. @Vectorized
There was a problem hiding this comment.
It looks like the compiler didn't clean the bits.
I have added some changes to ensure that.
|
Ok, did some changes:
|
cygaar
reviewed
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick draft implementation for #322 "Allowing general storage hitchhiking".