Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERC4907 #370
ERC4907 #370
Changes from 10 commits
8c9501a
b8d6890
159236f
3cd2864
112337c
78fc9b5
196b95f
bd082f9
97f22bc
13921ab
62c44bd
fb922e9
1f626a7
57c73ff
a5839ad
2b99f3a
e6d4512
7bd79c4
71b3379
bdcc569
cd48fd0
2715385
858ebdb
4498a4c
fef2e25
1e035d0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// for gas savings, the following lines of code can be deleted
// if the new owner want to change the user to zero address ,
// the new owner could call
setUser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. It’s just to stay faithful to the original implementation.
I personally feel that resetting user upon transfer like the original code is a good default behaviour.
But I also can see very valid use cases for keeping the user by default.
Let me think again with the team if it is better to reset or keep the user by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cygaar After some marinating, I'm feeling it's better to remove the auto user reset, as suggested.
Let the users add it on their own if they want.