Add payable gas optimization #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this makes sense. This follows the EIP and accommodates royalties. Also save that sweet sweet gas. |
cygaar
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://eips.ethereum.org/EIPS/eip-721, the following functions can be made payable.
safeTransferFromtransferFromapproveSaves 24 gas for
transferFrom.Oh, poll here: https://twitter.com/optimizoor/status/1563757003809648640
A potential use case is for paid pull-based transfers.
Tbh, this isn't that useful for royalties (anyone can do the trick described in https://twitter.com/optimizoor/status/1563806550971412480 to "enforce" royalties way more effectively via sheer inconvenience).