-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix min and max errors on windows #133
Conversation
How can I make this work on my end ? |
@BenasPaulikas at the moment you can do |
On windows version .on('data') doesn't works though child_process on('data') returns all text |
@BenasPaulikas Strange... must work 😕 Check this, uses ptyw.js and the data event works well on windows. |
@iiegor Apparently launching .exe gives no data emmitter, however if I launch .bat file which launch .exe file it's working good(cmd.exe /c file.exe). Strange.. |
@iiegor Will ptyw.js and pty.js will be merged someday ? |
@BenasPaulikas My apologies for closing this but this PR was opened the 10 of Sept and the author was active at that time and there wasn't any comment or interest meanwhile in merging this. |
@iiegor Strange, why it's being ignored? I saw lots of issues lately regarding this fix |
@chjj I hate to be blunt like this, but are you absolutely daft? This is an essential fix and you straight up ignored it. Are you even maintaining this anymore? It doesn't build with VS2015 either. You should think about updating winpty to a version not 3 fucking years old, maybe? Come on, @chjj. You have time to maintain this instead of writing useless crap like browser terminals which uses this in the first place. |
lol |
Nevermind, ptyw.js is an updated fork ( https://github.com/iiegor/ptyw.js ) @BenasPaulikas Looks like this will never be merged, author is too busy writing browser terminals in San Francisco. =P |
Use trailing whitespace rather than <br> in README
The latest commit that was made on peters/winpty fix this issues, so updating winpty will be fine (please remember publishing the pkg when you merge, thanks).
Fixes #131