Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix min and max errors on windows #133

Closed
wants to merge 3 commits into from
Closed

Conversation

iiegor
Copy link

@iiegor iiegor commented Sep 10, 2015

The latest commit that was made on peters/winpty fix this issues, so updating winpty will be fine (please remember publishing the pkg when you merge, thanks).

Fixes #131

This was referenced Sep 11, 2015
@BenasPaulikas
Copy link

How can I make this work on my end ?

@iiegor
Copy link
Author

iiegor commented Sep 21, 2015

@BenasPaulikas at the moment you can do npm install ptyw.js or use my fixed branch https://github.com/iiegor/pty.js/tree/win-fix

@BenasPaulikas
Copy link

On windows version .on('data') doesn't works though child_process on('data') returns all text

@iiegor
Copy link
Author

iiegor commented Sep 21, 2015

@BenasPaulikas Strange... must work 😕 Check this, uses ptyw.js and the data event works well on windows.

@BenasPaulikas
Copy link

@iiegor Apparently launching .exe gives no data emmitter, however if I launch .bat file which launch .exe file it's working good(cmd.exe /c file.exe). Strange..

@BenasPaulikas
Copy link

@iiegor Will ptyw.js and pty.js will be merged someday ?

@iiegor
Copy link
Author

iiegor commented Oct 11, 2015

@BenasPaulikas My apologies for closing this but this PR was opened the 10 of Sept and the author was active at that time and there wasn't any comment or interest meanwhile in merging this.

@BenasPaulikas
Copy link

@iiegor Strange, why it's being ignored? I saw lots of issues lately regarding this fix

@darkf
Copy link

darkf commented Aug 17, 2016

@chjj I hate to be blunt like this, but are you absolutely daft? This is an essential fix and you straight up ignored it. Are you even maintaining this anymore?

It doesn't build with VS2015 either. You should think about updating winpty to a version not 3 fucking years old, maybe?

Come on, @chjj. You have time to maintain this instead of writing useless crap like browser terminals which uses this in the first place.

@BenasPaulikas
Copy link

lol

@darkf
Copy link

darkf commented Aug 17, 2016

Nevermind, ptyw.js is an updated fork ( https://github.com/iiegor/ptyw.js )

@BenasPaulikas Looks like this will never be merged, author is too busy writing browser terminals in San Francisco. =P

ddm pushed a commit to ddm/pty.js that referenced this pull request Nov 8, 2017
Use trailing whitespace rather than <br> in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation fails (max is not a template of std among others)
3 participants