Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Apple Silicon #88

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Add support for Apple Silicon #88

merged 3 commits into from
Aug 2, 2023

Conversation

odow
Copy link
Collaborator

@odow odow commented Aug 2, 2023

This PR adds support for apple silicon. I've tested that it works locally.

Closes #61

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (87f8884) 93.66% compared to head (a85d6dd) 93.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files           3        3           
  Lines         379      379           
=======================================
  Hits          355      355           
  Misses         24       24           
Files Changed Coverage Δ
src/PATHSolver.jl 83.33% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Collaborator Author

odow commented Aug 2, 2023

Oh, I don't have permission to install https://github.com/marketplace/cirrus-ci here.

@chkwon if you have time, can you go to https://github.com/marketplace/cirrus-ci, scroll to the bottom, and follow the prompts to install a public plan?

image

@odow
Copy link
Collaborator Author

odow commented Aug 2, 2023

merging because I've tested this locally. We can add CI later

@odow
Copy link
Collaborator Author

odow commented Aug 2, 2023

actually I'll delete the Cirrus file until needed

@odow odow merged commit 3032aa4 into master Aug 2, 2023
8 of 9 checks passed
@odow odow deleted the od/silicon branch August 2, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PATHSolver doesn't build on aarch64-apple-darwin
1 participant