[docs] setDate triggerChange inverted behaviour

[mlazze]

File Reference

In docs it's implied that onChange events not firing is the default behaviour, but the default behaviour is to fire onChange event, unless false is passed as argument.

[RobbieTheWagner]

This seems to have been changed from previous versions https://github.com/chmln/flatpickr/blob/v2.3.2/src/flatpickr.js#L1259

I would argue that we should set the behavior back to the old way.

Why would we want an onChange fired when you set the initial value? Should only be when actually changed.

[chmln]

Funny enough, this exact issue bit me during plugin development, when a setDate() from an onChange hook caused stack overflow.

I think the previous value is more sensible.

[RobbieTheWagner]

@chmln I would agree! Should I create an issue for it, or is tracking via this PR okay? Can probably close this PR, if we are going to set it back to the old way. No need to update the docs in that case.

[chmln]

@rwwagner90 I'll just close this PR as soon as I revert the behavior

[RobbieTheWagner]

Thanks @chmln! Looking forward to the next release, so I can close out all the ember-flatpickr issues we encountered from this 😄

[RobbieTheWagner]

@chmln any chance we could get a release to patch this?