Fix infinite loop with controlled components #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of this line in flatpickr, if you don't explicitly pass
false
tosetDate
it will trigger events, including theonChange
event. This leads to an infinite loop when using this package as a controlled component.Alternatively, I believe you can bind to
onValueUpdate
instead ofonChange
, that's what the vue version of this package does and it doesn't seem to suffer from this issue.