-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plan to publish as a library crate? #194
Comments
What is your meaning, please? Do you mean that we should publish it as a Rust library? |
I would be happy if this were the case. For example, |
I think it is a good idea... @CosmicHorrorDev do you think so? I think I can work on it. It sounds funny for me. |
I could see it being useful. I think go ahead and start on it if you want 👍 |
Add config builder, test and support `&str` argument.
I don't think converting sd into a library is a good move as it introduces the burden of maintaining a stable public API, making future changes more cumbersome and necessitating in-depth versioning management. The regex crate already offers a better solution for finding and replacing, the only thing that sd adds on top of it as a library would be file mmaping. The crate maintainers will need to document the API and add additional tests beyond what's typical for CLI usage I personally don't think it's worth it for the future of the crate. |
Now that the last release is out I think I have to say that I changed by mind and don't think we should publish a library crate any time in the near future. There's too many ongoing and planned changes going on in This may change in the future, but I'll be closing this for now |
I think it would be nice to be able to use the functionality of sd from Rust code. Yes, we can do it with std::process::Command or something, but it is not type safe.
The text was updated successfully, but these errors were encountered: