Use 1 MB buffers to avoid silent errors #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portante
force-pushed
the
address-token-too-long
branch
2 times, most recently
from
79756fd to
05f2478
Compare
|
i am not sure what is the default of caddy https://caddyserver.com/docs/caddyfile/directives/request_body doesn't give the default here on nginx the default POST value seems to be 1MB https://docs.rackspace.com/support/how-to/limit-file-upload-size-in-nginx/ |
The new published log entries in both the client and server contain the the original payload headers, and for the server the request ID, allowing one to track down behaviors from know sources (e.g. GitHub posts a list of events it sent to a web hook with the headers used).
See r3labs/sse#158, "Improve receive message error handling." Fixes chmouel#77, "`ERROR gosmee bufio.Scanner: token too long`".
portante
force-pushed
the
address-token-too-long
branch
from
05f2478 to
dc14cd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See r3labs/sse#158, "Improve receive message error handling."
Fixes #77, "
ERROR gosmee bufio.Scanner: token too long".I filed this as 2 separate commits so that the actual fix is separate from the logging changes I made as part of my debugging efforts (commit message body below for the supporting commit):
Layered on top of #83.