Skip to content

Commit

Permalink
Use upstream image for the nop image
Browse files Browse the repository at this point in the history
This is a very cheeky hack, sidecar is currently broken with our nop image so we
just use nightly `nop` from upstream CI. `nop` should not change or do anything
differently with a different base so we should be safe until
tektoncd#1347 gets fixed.

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
  • Loading branch information
chmouel committed Sep 24, 2019
1 parent 6e551ef commit 8cb09b9
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions openshift/e2e-tests-openshift.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ function install_tekton_pipeline() {

function create_pipeline() {
resolve_resources config/ tekton-pipeline-resolved.yaml "nothing" $OPENSHIFT_REGISTRY/$OPENSHIFT_BUILD_NAMESPACE/stable

# NOTE(chmou): This is a very cheeky hack, sidecar is currently broken with
# our nop image so we just use nightly `nop` from upstream CI. `nop` should
# not change or do anything differently with a different base so we should be
# safe until https://github.com/tektoncd/pipeline/issues/1347 gets fixed
sed -i -n 's%"-nop-image.*%"-nop-image", "gcr.io/tekton-nightly/github.com/tektoncd/pipeline/cmd/nop:latest",%;p' tekton-pipeline-resolved.yaml

oc apply -f tekton-pipeline-resolved.yaml
}

Expand Down

0 comments on commit 8cb09b9

Please sign in to comment.