Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement note rule CPMR0062 - Chocolatey Dependency #35

Closed
2 tasks done
Tracked by #30
AdmiringWorm opened this issue Jan 28, 2024 · 1 comment · Fixed by #46
Closed
2 tasks done
Tracked by #30

Implement note rule CPMR0062 - Chocolatey Dependency #35

AdmiringWorm opened this issue Jan 28, 2024 · 1 comment · Fixed by #46
Assignees
@AdmiringWorm
Labels
5 - Released The issue has been resolved, and released to the public for consumption Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.2.0

Comments

@AdmiringWorm
Copy link
Member

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

No response

Describe The Solution. Why is it needed?

We should implement the note rule available in Package Validator that adds a note to moderators when Chocolatey CLI has been added as a dependency to the nuspec file.

This should be implemented in a simple way that only checks if the presence of the chocolatey is defined as a dependency, and flag it if it is (no matter the case).

Additional Context

Rule Documentation: https://ch0.co/rules/cpmr0062

The documentation is currently stubbed out, and is required to be filled out as well in the docs repository

Related Issues

No response
@AdmiringWorm AdmiringWorm added Improvement Issues that enhances existing functionality, or adds new features 0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint labels Jan 28, 2024
@AdmiringWorm AdmiringWorm added this to the 0.2.0 milestone Jan 28, 2024
@AdmiringWorm AdmiringWorm mentioned this issue Jan 28, 2024
Closed
8 tasks
@AdmiringWorm AdmiringWorm self-assigned this Apr 25, 2024
@AdmiringWorm AdmiringWorm added 2 - Working A user or team member has started working on the issue and removed 0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint labels Apr 25, 2024
AdmiringWorm added a commit to AdmiringWorm/chocolatey-community-validation that referenced this issue May 6, 2024
@AdmiringWorm
(chocolatey-community#35) Implement note rule CPMR0062
45788bc 
This implements the note rule CPMR0062 - Chocolatey Dependency, which
checks if there is a dependency on Chocolatey CLI defined in the nuspec
file. This is checked as normally there is no need to define Chocolatey
CLI as a dependency, unless a specific feature is being used. As such,
it is considered to be an anti-pattern to define one.
@AdmiringWorm AdmiringWorm mentioned this issue May 6, 2024
Merged
10 tasks
@corbob corbob closed this as completed in #46 May 7, 2024
corbob added a commit that referenced this issue May 7, 2024
@corbob
Merge pull request #46 from AdmiringWorm/35-rule-cpmr0062
e829301 
(#35) Implement note rule CPMR0062
@corbob corbob added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 2 - Working A user or team member has started working on the issue labels May 7, 2024
AdmiringWorm added a commit to AdmiringWorm/chocolatey-community-validation that referenced this issue Dec 11, 2024
@AdmiringWorm
Merge branch 'release/0.2.0'
e88ef08 
* release/0.2.0: (21 commits)
  (maint) Fix incorrect label used in config
  (chocolatey-community#58) Implement requirement rule CPMR0074
  (chocolatey-community#28) Add rule to disallow icon URL using GitHub links
  (chocolatey-community#37) Implement note rule CPMR0068
  (chocolatey-community#36) Implement note rule CPMR0067
  (maint) Set explicit PlatformTarget for console
  (maint) synced local '.github/ISSUE_TEMPLATE/' with remote '.github/ISSUE_TEMPLATE/'
  (chocolatey-community#38) Add rule for validating ID length
  (chocolatey-community#39) Add rule for validating underscore in ID
  (chocolatey-community#34) Implement note rule CPMR0061 - Id Contains "."
  (maint) synced local '.github/PULL_REQUEST_TEMPLATE.md' with remote '.github/PULL_REQUEST_TEMPLATE.md'
  (build) Update Chocolatey.Cake.Recipe to latest
  (chocolatey-community#35) Implement note rule CPMR0062
  (build) Update to latest Recipe package
  (maint) synced local '.github/ISSUE_TEMPLATE/' with remote '.github/ISSUE_TEMPLATE/'
  (chocolatey-community#32) Update Help URLs to short link
  (chocolatey-community#29) Add missing release notes to generated packages
  (maint) Update extension name in Readme
  (maint) synced local '.templates/' with remote '.github/GitReleaseManager/.templates/'
  (chocolatey-community#26) Use milestone for license URL replacement
  ...
@AdmiringWorm AdmiringWorm added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Dec 11, 2024
@AdmiringWorm
Copy link
Member Author

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
5 - Released The issue has been resolved, and released to the public for consumption Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

(#35) Implement note rule CPMR0062 AdmiringWorm/chocolatey-community-validation
2 participants
@AdmiringWorm @corbob